[Diagnostics] Ported tuple mismatch diagnostic to new diagnostic framework #26391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
sl
force-pushed
the
port-tuple-assignment-diagnostic
branch
from
af44c9c to
a3b56c2
Compare
|
@swift-ci please smoke test |
theblixguy
reviewed
Jul 29, 2019
| var (m, n) = callee1() // expected-error{{'(Int, Int, Int)' is not convertible to '(_, _)', tuples have a different number of elements}} | ||
| var (o, p, q, r) = callee1() // expected-error{{'(Int, Int, Int)' is not convertible to '(_, _, _, _)', tuples have a different number of elements}} | ||
| var (m, n) = callee1() // expected-error{{'(Int, Int, Int)' is not convertible to '(Int, Int)', tuples have a different number of elements}} | ||
| var (o, p, q, r) = callee1() // expected-error{{'(Int, Int, Int)' is not convertible to '(Int, Int, Int, Any)', tuples have a different number of elements}} |
xedin
requested changes
Jul 29, 2019
| var (m, n) = callee1() // expected-error{{'(Int, Int, Int)' is not convertible to '(_, _)', tuples have a different number of elements}} | ||
| var (o, p, q, r) = callee1() // expected-error{{'(Int, Int, Int)' is not convertible to '(_, _, _, _)', tuples have a different number of elements}} | ||
| var (m, n) = callee1() // expected-error{{'(Int, Int, Int)' is not convertible to '(Int, Int)', tuples have a different number of elements}} | ||
| var (o, p, q, r) = callee1() // expected-error{{'(Int, Int, Int)' is not convertible to '(Int, Int, Int, Any)', tuples have a different number of elements}} |
|
@swift-ci please smoke test |
sl
force-pushed
the
port-tuple-assignment-diagnostic
branch
from
e1556d5 to
6dd88c2
Compare
|
@swift-ci please smoke test |
xedin
requested changes
Aug 2, 2019
sl
force-pushed
the
port-tuple-assignment-diagnostic
branch
from
6dd88c2 to
0fa9ec3
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request ports the old tuple assignment diagnostic to the new diagnostic framework. Additionally adds tests relating to the diagnostic and updates the tests so they no longer have
_types.Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-11224.