[5.1][CSFix] Delay missing unwrap locator simplification until diagnostic
#26413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of keeping two locators in the fix let's store only the original locator and simplify it later in process of emitting a diagnostic. That helps to avoid some duplicate work as well as makes sure that locators supplied to the diagnostic always have an anchor. Resolves: rdar://problem/53344815 Resolves: rdar://problem/53238058 (cherry picked from commit 795a84a)
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of keeping two locators in the fix let's store only the
original locator and simplify it later in process of emitting
a diagnostic. That helps to avoid some duplicate work as well
as makes sure that locators supplied to the diagnostic always
have an anchor.
Issue: rdar://problem/53238058, rdar://problem/53344815
Scope: Constraint solver in diagnostic mode.
Risk: Very Low.
Testing: Added compiler regression tests.
Reviewed by: @DougGregor
Resolves: rdar://problem/53344815
Resolves: rdar://problem/53238058
(cherry picked from commit 795a84a)