[AutoDiff] Simplify AD-related SILGen logic. #26430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Do not unset `@differentiable` attribute functions for consistent
same-module and cross-module `[differentiable]` SILGen behavior.
- Always create vtable entry thunks for JVPs/VJPs.
- Previously, vtable entry thunks were conditionally generated
based on an ad-hoc condition.
- Update tests.
Todo: remove JVP/VJP names from `[differentiable]` attribute.
|
@swift-ci Please test tensorflow |
rxwei
approved these changes
Jul 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@differentiableattribute functions for consistentsame-module and cross-module
[differentiable]SILGen behavior.based on an ad-hoc condition.
Todo: remove JVP/VJP names from
[differentiable]attribute.