Skip to content

[TF] Remove TensorFlowUnittest. #26447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 5, 2019
Merged

[TF] Remove TensorFlowUnittest. #26447

merged 2 commits into from
Aug 5, 2019

Conversation

dan-zheng
Copy link
Contributor

TensorFlowUnittest is deprecated.
TensorFlow module and tests have moved to https://github.com/tensorflow/swift-apis.

@dan-zheng
[TF] Remove TensorFlowUnittest.
12407bf 
TensorFlowUnittest is deprecated.
TensorFlow module and tests have moved to https://github.com/tensorflow/swift-apis.
@dan-zheng dan-zheng added the tensorflow This is for "tensorflow" branch PRs. label Aug 1, 2019
@dan-zheng dan-zheng requested review from rxwei, pschuh and bgogul August 1, 2019 03:05
@dan-zheng
Copy link
Contributor Author

@swift-ci Please test tensorflow

@dan-zheng
Copy link
Contributor Author

test/TensorFlowRuntime/tensor_autodiff_control_flow.swift needs to be ported to Tests/TensorFlowTests/TensorAutoDiffTests.swift in tensorflow/swift-apis.

FAIL: Swift(macosx-x86_64) :: TensorFlowRuntime/tensor_autodiff_control_flow.swift (8201 of 12272)
******************** TEST 'Swift(macosx-x86_64) :: TensorFlowRuntime/tensor_autodiff_control_flow.swift' FAILED ********************
/Users/swiftci/jenkins/workspace/swift-PR-TensorFlow-macOS/swift/test/TensorFlowRuntime/tensor_autodiff_control_flow.swift:12:8: error: no such module 'TensorFlowUnittest'
import TensorFlowUnittest
       ^

********************
Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
Testing Time: 811.42s
********************
Failing Tests (1):
    Swift(macosx-x86_64) :: TensorFlowRuntime/tensor_autodiff_control_flow.swift

  Expected Passes    : 12034
  Expected Failures  : 26
  Unsupported Tests  : 211
  Unexpected Failures: 1

@dan-zheng dan-zheng mentioned this pull request Aug 1, 2019
Closed
@rxwei
Copy link
Contributor

rxwei commented Aug 3, 2019

@swift-ci please test tensorflow

1 similar comment
@rxwei
Copy link
Contributor

rxwei commented Aug 3, 2019

@swift-ci please test tensorflow

@dan-zheng
Copy link
Contributor Author

Thanks @rxwei!

@dan-zheng dan-zheng merged commit 499c875 into swiftlang:tensorflow Aug 5, 2019
@dan-zheng dan-zheng deleted the remove-tf-unittest branch August 5, 2019 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rxwei rxwei rxwei approved these changes

@bgogul bgogul bgogul approved these changes

@pschuh pschuh Awaiting requested review from pschuh

Assignees
No one assigned
Labels
tensorflow This is for "tensorflow" branch PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dan-zheng @rxwei @bgogul