[ConstraintSystem] Add a fix to ignore contextual type mismatch #26459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @sl This is still work in progress since I have to port some tailored diagnostics over but you can see that there are some decent improvements here already. I think this is final major preliminary work required before porting argument-to-parameter conversion mismatches. |
xedin
force-pushed
the
diag-conversion-to-specified-type
branch
3 times, most recently
from
cd36d9f to
74e3647
Compare
xedin
force-pushed
the
diag-conversion-to-specified-type
branch
from
74e3647 to
7c11684
Compare
Ignore contextual type mismatch to allow solver to make progress towards solution and diagnose the problem later.
…l mismatches to new framework
…ConstraintSystem Functions like `isRawRepresentable*` and `conformsToKnownProtocol` have to be be shared between CSDiag and new diagnostics framework until relevant code is removed from the former.
…ns are attempted This makes sure that solver is able to produce specialized fixes in some cases e.g. existential conversions, mismatched generic arguments, or force unwraps before fallback to generic `cannot convert X to Y` failure.
Behavior changed when it became possible to omit `return` in single expression functions but it hasn't been diagnosed correctly.
Detect that contextual conversion is between a dictionary type and an array type which comes form an array literal and produce a tailored diagnostic.
…ic expressoin If contextual failure is detected in sub-expression (through type-check call via CSDiag), let's make sure that fix-it is always anchored at semantic expression otherwise it could be attached to the paren representing whole argument list.
…ismatch If the only difference between two functions is `throws` and it is not a subtype relationship, let's repair the problem by dropping `throws` attribute and letting solver continue to search for a solution, which would later be diagnosed.
xedin
force-pushed
the
diag-conversion-to-specified-type
branch
from
7c11684 to
d1186f2
Compare
…ith `nil`) Remove the rest of the obsolete code from `diagnoseContextualConversionError` and port diagnostic about string indexing to new diagnostic framework.
…protocol composition
xedin
force-pushed
the
diag-conversion-to-specified-type
branch
from
d1186f2 to
129092e
Compare
|
@swift-ci please test |
|
Besides 2 diagnostic regressions related to protocol composition I consider this done. |
|
I'll address them in the follow-up PR since this one is getting pretty big. |
DougGregor
approved these changes
Aug 14, 2019
hborla
approved these changes
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore contextual type mismatch to allow solver to make progress
towards solution and diagnose the problem later.