[AutoDiff] Handle @inout_aliasable when converting associated functions
#26484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions. When reapplying a `partial_apply` for a JVP/VJP, if the argument has convention `@inout_aliasable`, it is a noescape mutable capture and the underlying value should not be retained. This fixes a memory leak when a noescape closure being differentiated captures a mutable self.
|
@swift-ci please test tensorflow |
dan-zheng
approved these changes
Aug 4, 2019
rxwei
force-pushed
the
ad-inout-aliasable-capture
branch
from
dc73d38 to
0284b03
Compare
|
@swift-ci please test tensorflow |
1 similar comment
|
@swift-ci please test tensorflow |
It appears that this is the only special case. I asked a question on the forum. |
dan-zheng
approved these changes
Aug 6, 2019
rxwei
force-pushed
the
ad-inout-aliasable-capture
branch
from
0284b03 to
19e86c4
Compare
|
@swift-ci please test tensorflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reapplying a
partial_applyfor a JVP/VJP, if the argument has convention@inout_aliasable, it is a noescape mutable capture and the underlying value should not be retained. This fixes a memory leak when a noescape closure being differentiated captures a mutable self.Resolves eaplatanios/swift-ale#1.