Skip to content

[Gardening] Fix example of SyntaxParsingContext in comment #26487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2019
Merged

[Gardening] Fix example of SyntaxParsingContext in comment #26487

merged 1 commit into from
Aug 5, 2019

Conversation

kitasuke
Copy link
Contributor

@kitasuke kitasuke commented Aug 5, 2019

Overview

SyntaxParsingContext LocalCtxt(SyntaxContext, SyntaxKind::ParenExpr); is correct, not SyntaxParsingContext LocalCtxt(SyntaxKind::ParenExpr, SyntaxContext); according to definition below

  SyntaxParsingContext(SyntaxParsingContext *&CtxtHolder, SyntaxKind Kind)
      : SyntaxParsingContext(CtxtHolder) {
    setCreateSyntax(Kind);
  }

@nkcsgexi
Copy link
Contributor

nkcsgexi commented Aug 5, 2019

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit 85b9bfa into swiftlang:master Aug 5, 2019
@kitasuke kitasuke deleted the fix-SyntaxParsingContext-docs branch August 6, 2019 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kitasuke @nkcsgexi @swift-ci