Remove build-script-impl target calculation #26495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's duplicated between the build-script and the -impl, removing code from build-script-impl is good.
Rostepher
approved these changes
Aug 5, 2019
|
Assuming this passes testing I'm all for getting rid of this cruft. |
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test Linux |
|
Build failed |
|
@swift-ci please test Linux platform |
|
Build failed |
|
Seems that IndexStoreDB is unhappy: |
|
@swift-ci please test Linux platform |
|
Build failed |
|
@swift-ci please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes some code that was duplicated between
build-scriptandbuild-script-impl. It was duplicated between these for migration purposes, but isn't needed for that purpose anymore.