[AST] Be lenient with PatternBindingIntializer without PatBindingDecl #26546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test macOS platform |
rintaro
force-pushed
the
ide-completion-rdar53034550
branch
from
f694bbc to
055c2b5
Compare
PatternBindingInitializer may not be attached to any
PatternBindingDecl. e.g.
struct S {
@CustomAttr(something)
}
In this case DeclContext for 'something' is PatternBindingInitializer,
but it doesn't have PatternBindingDecl because it's not written yet.
Fixes a crash in code-completion.
rdar://problem/53034550
rintaro
force-pushed
the
ide-completion-rdar53034550
branch
from
055c2b5 to
428bbe1
Compare
|
@swift-ci Please smoke test |
DougGregor
approved these changes
Aug 13, 2019
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PatternBindingInitializermay not be attached to anyPatternBindingDecl. e.g.In this case
DeclContextforsomethingisPatternBindingInitializer, but it doesn't havePatternBindingDeclbecause it's not written yet.Fixes a crash in code-completion.
rdar://problem/53034550