Skip to content

Updated the LLDB checkout commit. #26585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2019
Merged

Conversation

eaplatanios
Copy link

Without this change it's not possible to build toolchains currently. Tested on MacOS.

cc @dan-zheng @rxwei

@dan-zheng
Copy link
Contributor

I looked at the before and after commits; this update makes sense.

@dan-zheng
Copy link
Contributor

Testing should not be meaningful because CI does not test building lldb.
Running tests nonetheless (to make sure update-checkout works).

@dan-zheng
Copy link
Contributor

@swift-ci Please test tensorflow

@dan-zheng dan-zheng added the tensorflow This is for "tensorflow" branch PRs. label Aug 10, 2019
@dan-zheng dan-zheng merged commit c189a7e into swiftlang:tensorflow Aug 10, 2019
@burmako
Copy link

burmako commented Aug 12, 2019

Sorry guys! This is my fault. I should've checked that our internal merge script did everything correctly. Will keep this in mind next time I'm on the merge rotation.

@eaplatanios
Copy link
Author

No worries @burmako! It's actually weird that there are no integration tests for LLDB. According to this discussion this may soon change though. :)

@AnthonyLatsis AnthonyLatsis added the update-checkout Area → utils: the `update-checkout` script label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tensorflow This is for "tensorflow" branch PRs. update-checkout Area → utils: the `update-checkout` script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants