[AutoDiff] Revamp PullbackInfo
#26587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartchr808
force-pushed
the
revamp-linear-map-info
branch
from
4694266 to
725308a
Compare
|
@swift-ci please test tensorflow |
rxwei
reviewed
Aug 10, 2019
rxwei
reviewed
Aug 10, 2019
dan-zheng
reviewed
Aug 10, 2019
bartchr808
force-pushed
the
revamp-linear-map-info
branch
from
608844b to
b9637c9
Compare
bartchr808
force-pushed
the
revamp-linear-map-info
branch
from
b9637c9 to
1a7e8b6
Compare
rxwei
reviewed
Aug 11, 2019
| return false; | ||
| } | ||
|
|
||
| void LinearMapInfo::populateLinearMapStructDeclarationFields( |
There was a problem hiding this comment.
I'm fine with checking this function to unblock things, but it should be broken down into multiple functions to reduce nesting.
There was a problem hiding this comment.
No worries I can make it part of this PR. Currently rebuilding my Xcode build, so will push a separate commit to make this change soon once it finishes.
There was a problem hiding this comment.
Added this change in my latest commit, separated out the code of when I find an apply instruction.
bartchr808
force-pushed
the
revamp-linear-map-info
branch
2 times, most recently
from
0fa5f61 to
332c1f5
Compare
bartchr808
force-pushed
the
revamp-linear-map-info
branch
from
332c1f5 to
81b8592
Compare
|
@swift-ci please test tensorflow |
rxwei
approved these changes
Aug 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PullbackInfo->LinearMapInfoWith the introduction of Forward Mode Differentiation, the name
PullbackInfois not correct anymore. To recall, it stores information about the JVP/VJP generation. thus, a more general name ofLinearMapInfomore appropriately represents what it stores.Specifically, it stores the differential and pullback functions, which are linear functions. We map those functions to the original apply calls, which is where
LinearMapInfoandlinearMapStructscomes from.Revamp
linearMapStructcreation to occur before JVP/VJP emissionIn my forward mode PR #26057 , I experienced an LLVM IR bug. What was going on is that it was caching the linear map structs before the linear functions were added. Those functions were being added while we were visiting the relevant instructions in JVP/VJP emission.
The solution to avoid this caching problem was to bring the part where we add the linear map functions earlier to when we create the
LinearMapInfo. Thus, when the JVP/VJP emission pass occurs, it will cache the full linear map struct.