SR-11261: [Diagnostics][Qol] Parser recovery for keyword #26596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodaFi
reviewed
Aug 12, 2019
rintaro
reviewed
Aug 13, 2019
rintaro
reviewed
Aug 13, 2019
LucianoPAlmeida
force-pushed
the
SR-11261-parser-recovery-for-keyword
branch
from
e798a3a to
c0d1301
Compare
rintaro
reviewed
Aug 15, 2019
rintaro
reviewed
Aug 16, 2019
LucianoPAlmeida
force-pushed
the
SR-11261-parser-recovery-for-keyword
branch
from
eb165d6 to
32dc022
Compare
rintaro
reviewed
Aug 19, 2019
LucianoPAlmeida
force-pushed
the
SR-11261-parser-recovery-for-keyword
branch
from
35763cf to
99de498
Compare
|
Just updated @rintaro 👍 |
|
@swift-ci Please smoke test |
|
The change looks good to me! Please update |
|
Sure, thank's @rintaro |
|
@rintaro The stmt tests are updated 👍 Also just ran lit tests on /swift/test/ and seems like all others are ok too :)) |
|
@swift-ci Please smoke test |
|
@rintaro The Linux failure seems unrelated. CI issue? |
|
@swift-ci Please smoke test Linux |
|
Thank you Luciano! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves SR-11261.
cc @rintaro