Skip to content

[Diagnostics] Don't crash when gathering info about property wrapper … #26628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2019

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Aug 12, 2019

…in l-value base

Make TypeBase::getTypeOfMember more resilient to base type
being either an l-value (which we can look through), or an
error type - in such can it would return immediately.

Resolves: rdar://problem/54184846

@xedin xedin requested a review from DougGregor August 12, 2019 23:44
@xedin
Copy link
Contributor Author

xedin commented Aug 12, 2019

@swift-ci please test

…in l-value base

Make `TypeBase::getTypeOfMember` more resilient to base type
being either an l-value (which we can look through), or an
error type - in such can it would return immediately.

Resolves: rdar://problem/54184846
@xedin
Copy link
Contributor Author

xedin commented Aug 12, 2019

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented Aug 12, 2019

@swift-ci please test source compatibility

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - a41cc4b1d32c92c20cc665583c1721aee98ac16f

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - a41cc4b1d32c92c20cc665583c1721aee98ac16f

@xedin xedin merged commit 2a69e9c into swiftlang:master Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants