[5.1][Diagnostics] Don't crash when gathering info about property wrapper … #26629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
xedin
changed the title
AnnaZaks
approved these changes
Aug 13, 2019
…in l-value base Make `TypeBase::getTypeOfMember` more resilient to base type being either an l-value (which we can look through), or an error type - in such can it would return immediately. Resolves: rdar://problem/54184846 (cherry picked from commit c67cf88) (cherry picked from commit 5c4b349eb6cae5c0f128a17ee7dddda9e7f5ab1a)
xedin
force-pushed
the
rdar-54184846-5.1
branch
from
5c4b349 to
b483549
Compare
|
@swift-ci please test |
|
Build failed |
|
That failure doesn't make sense: |
|
@swift-ci please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…in l-value base
Make
TypeBase::getTypeOfMembermore resilient to base typebeing either an l-value (which we can look through), or an
error type - in such can it would return immediately.
Issue: rdar://problem/54184846
Scope: Constraint solver in diagnostic mode.
Risk: Very Low.
Testing: Added compiler regression tests.
Reviewed by: @DougGregor
Resolves: rdar://problem/54184846
(cherry picked from commit c67cf88)