ABI/API checker: avoid printing fully qualified names in generic signature #26642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ature The heuristics to decide whether fully qualified type names should be printed may work differently when generating the baseline and when importing from just built frameworks. This patch makes it consistent so that such false positives won't happen. rdar://54276347
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
There could be cases where several modules having types of the same name. Using fully qualified names could help us detect changing from using one of them to another. The commit also updates the existing ABI/API baselines to incorporate such change.
nkcsgexi
force-pushed
the
unqualified-name-api
branch
from
8b2f8a3 to
4b8abdf
Compare
|
@swift-ci please smoke test |
|
@swift-ci Please clean test Linux platform |
|
Build failed |
|
@swift-ci Please smoke test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The heuristics to decide whether fully qualified type names should be printed may
work differently when generating the baseline and when importing from just built
frameworks. This patch makes it consistent so that such false positives won't happen.
rdar://54276347