[5.1] Installation support for sourcekit-lsp #26703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The smoke test preset tests sourcekit-lsp, and the full test should too. Note: on Linux this was already working.
…-lsp At a minimum, we need to install libIndexStore to enable testing the indexer, but it's better to also include clang/clangd, since this lets us enable all of our tests on these bots. This commit uses the swift-install-components and llvm-install-components from the Package bots, which increases the similarity between our PR tests and package bots. In addition to the sourcekit-lsp/indexstore-db PR test bots, this affects the following bots that test indexstore-db and didn't already install clang: * Linux * incremental * incremental long test * swiftpm PR test * macOS * PR test * PR smoke test * incremental * swiftpm PR test Based on looking at recent build logs for the package bots, this should only add <5 seconds to the incremental build.
Add --install-sourcekit-lsp option to build-script and update presets for package bots to install it. Conflicts: utils/build-script utils/build_swift/driver_arguments.py utils/build_swift/tests/expected_options.py
This was referenced Aug 16, 2019
|
swiftlang/indexstore-db#51 @swift-ci please build toolchain |
|
Build failed |
|
macOS Toolchain Install command |
|
macOS failure is from pylint: |
|
Linux Toolchain (Ubuntu 16.04) Install command |
akyrtzi
approved these changes
Aug 17, 2019
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick to 5.1:
Add --install-sourcekit-lsp option to build-script and update presets for package bots to install it. Also adds missing install actions to a few test presets to make it possible to test sourcekit-lsp.