[Diagnostics][NFC]Move fix-it text formatting later in the diagnostics pipeline #26711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are defined with macros like errors/warnings/notes, and make use of format strings and diagnostic arguments. The intent is to leverage diagnostic arguments in the future to disambiguate ambiguously spelled types. Ported a few miscellaneous fix-its to the new system
Defer fix-it text formatting to individual DiagnosticConsumers so it can be customized or omitted as needed, similar to how it's done for errors, warnings, and notes Move DiagnosticArgument, DiagnosticFormatOptions, and formatDiagnosticText out of DiagnosticEngine and into DiagnosticFormatting, to avoid circular dependencies between DiagnosticEngine and DiagnosticConsumer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on and includes the commit from #26612
Defer fix-it text formatting to individual DiagnosticConsumers so it can be customized or omitted as needed, similar to how it's done for errors, warnings, and notes
Move DiagnosticArgument, DiagnosticFormatOptions, and formatDiagnosticText out of DiagnosticEngine and into DiagnosticFormatting, to avoid circular dependencies between DiagnosticEngine and DiagnosticConsumer (this is the bulk of the diff, but should be a generally beneficial refactor)