[IDE] Fix code completion crash after already-typechecked ApplyExpr #26723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Build failed |
nathawes
force-pushed
the
r54047322-fix-completion-crash-in-addFunctionCallPattern
branch
from
b7d6805 to
d68f669
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
This was due to us unconditionally setting the referenced decl to be the decl referenced by the ApplyExpr's function, when we should only do that for SelfApplyExprs. This caused a crash for calls returning a function type due to a mismatch between the resulting type (the function type the applied function returns) vs the referenced decl signature (the signature of the applied function itself). Resolves rdar://problem/53034130.
nathawes
force-pushed
the
r54047322-fix-completion-crash-in-addFunctionCallPattern
branch
from
d68f669 to
7bcba14
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
nathawes
deleted the
r54047322-fix-completion-crash-in-addFunctionCallPattern
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was due to us unconditionally setting the referenced decl to be the decl referenced by the
ApplyExpr's function, when we should only do that forSelfApplyExprs. This caused a crash for calls returning a function type due to a mismatch between the arity of expression's type (the function type the applied function returns) and the referenced decl (the signature of the applied function itself).Resolves rdar://problem/53034130.