Skip to content

[TensorFlow] Fix LLDB compilation. #26789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 23, 2019
Merged

Conversation

eaplatanios
Copy link

@rxwei @pschuh this should fix TF-770.

@rxwei
Copy link
Contributor

rxwei commented Aug 22, 2019

@swift-ci please clean test tensorflow

Copy link
Contributor

@pschuh pschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, This drops all our local changes to lldb. I don't think we can merge this pr.

@rxwei
Copy link
Contributor

rxwei commented Aug 22, 2019

ah right, I forgot about that.

Copy link
Contributor

@pschuh pschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lldb should be: 27b495a4292696b48389ed109b0cf232a125e614

@eaplatanios
Copy link
Author

Thanks @pschuh ! I wasn't aware there were S4TF-specific changes. I updated the commit hash.

@pschuh
Copy link
Contributor

pschuh commented Aug 22, 2019

@swift-ci please clean test tensorflow

1 similar comment
@pschuh
Copy link
Contributor

pschuh commented Aug 22, 2019

@swift-ci please clean test tensorflow

@pschuh pschuh merged commit 56abb79 into swiftlang:tensorflow Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants