Requestify Class Ancestry Flags #26794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
slavapestov
approved these changes
Aug 22, 2019
slavapestov
approved these changes
Aug 23, 2019
| HasForcedEmittedMembers : 1, | ||
|
|
||
| /// Information about the class's ancestry. | ||
| Ancestry : 7, |
There was a problem hiding this comment.
Since these are used rather frequently, I would imagine making this request ExternallyCached would still be profitable. Or maybe not...
|
|
||
| AncestryOptions ClassDecl::checkAncestry() const { | ||
| return AncestryOptions(evaluateOrDefault(getASTContext().evaluator, |
There was a problem hiding this comment.
Can you have the request return AncestryOptions instead of AncestryFlags to avoid the coercion?
There was a problem hiding this comment.
OptionSet doesn’t have an equality operator for good reason (see the file). I’m sure Sufficiently Magic Template Nonsense will let us do this eventually.
|
⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.