[IDE][Sema] Fix code completion unreachable/hang in TypeBase::getContextSubtitutions #26799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…extSubtitutions There are paths from Code completion giving it an UnboundGenericType, which it doesn't expect. This patch: 1) Updates the code completion paths to not attempt substitution on UnboundGenericTypes 2) Updates getContextSubstitutions to assert and break out of the loop when given an unhandled type to avoid hanging release builds if a similar bug occurs in future. Resolves rdar://problem/53959978
|
@swift-ci please test |
slavapestov
approved these changes
Aug 23, 2019
|
Thank you Nathan! |
nathawes
deleted the
r53959978-code-completion-hang-in-getContextSubstitutions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are paths from code completion giving it an
UnboundGenericType, which it doesn't expect.This patch:
UnboundGenericTypesgetContextSubstitutionsto assert and break out of the loop when given an unhandled type to avoid hanging release builds if a similar bug occurs in future.Resolves rdar://problem/53959978