[Serialization] Collapse indirection in DeclContextID #26813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
For code size @swift-ci Please smoke benchmark |
slavapestov
approved these changes
Aug 23, 2019
|
…oh wait, that is code size rather than swiftmodule size. Oh well. |
|
Shaves 0.6% off of the stdlib compiled module for macOS, and 1% off the one for Foundation. |
This comment has been minimized.
This comment has been minimized.
|
What's the downside? That it replaces proven code with new code? |
|
Mainly that there's not a good common name for the un-templated function. |
jrose-apple
force-pushed
the
a-more-direct-approach
branch
from
4cab539 to
2f73f9a
Compare
|
@varungandhi-apple, any thoughts? Think I should wait for Brent to get back? @swift-ci Please smoke test |
varungandhi-apple
approved these changes
Aug 27, 2019
...by making it a tagged union of either a DeclID or a LocalDeclContextID. This should lead to smaller module files and be slightly more efficient to deserialize, and also means that every AST entity kind is serialized in exactly one way, which allows for the following commit's refactoring.
No intended functionality change (other than a small reorder).
jrose-apple
force-pushed
the
a-more-direct-approach
branch
from
2f73f9a to
6bd0421
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...by making it a tagged union of either a DeclID or a LocalDeclContextID. This should lead to smaller module files and be slightly more efficient to deserialize, and also means that every AST entity kind is serialized in exactly one way, which allows factoring out a common loop in writing AST block entities.
I suggest reviewing each commit separately. I'm not entirely convinced the second one is worth it.