Skip to content

[AutoDiff] Remove CotangentVector, after deprecation. #26829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2019

Conversation

rxwei
Copy link
Contributor

@rxwei rxwei commented Aug 25, 2019

CotangentVector was deprecated in #24825 and the deprecation was released as part of Swift for TensorFlow v0.4. Now it's time to remove it.

`CotangentVector` was deprecated in swiftlang#24825 and the deprecation was released as part of Swift for TensorFlow v0.4. Now it's time to remove it.
@rxwei rxwei added the tensorflow This is for "tensorflow" branch PRs. label Aug 25, 2019
@rxwei
Copy link
Contributor Author

rxwei commented Aug 25, 2019

@swift-ci please test tensorflow

@rxwei rxwei requested a review from dan-zheng August 25, 2019 07:46
Copy link
Contributor

@dan-zheng dan-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed via grep that there are no remaining usages of CotangentVector of:

@rxwei
Copy link
Contributor Author

rxwei commented Aug 25, 2019

@dan-zheng thanks for grepping!

@rxwei rxwei merged commit aa4fd59 into swiftlang:tensorflow Aug 25, 2019
@rxwei rxwei deleted the remove-cotan-for-real branch August 25, 2019 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tensorflow This is for "tensorflow" branch PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants