[Testing] Fix some build warnings #26840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test macos |
mikeash
reviewed
Aug 26, 2019
| @@ -34,6 +34,10 @@ | |||
| #include <fcntl.h> | |||
| #endif | |||
|
|
|||
| #if defined(__clang__) || defined(__GNUC__) | |||
| #define NORETURN __attribute__((noreturn)) | |||
| #endif | |||
There was a problem hiding this comment.
Do we need an #else #define NORETURN here for other compilers?
There was a problem hiding this comment.
Oh, duh. Ya. Normally I'd not ifdef this, but given that Windows support is being pushed forward, I thought I'd make a nod towards portability. See also: #26868
mikeash
reviewed
Aug 26, 2019
| @@ -62,7 +62,8 @@ class Observer : public FrontendObserver { | |||
|
|
|||
| } | |||
|
|
|||
| int main(int argc, const char *argv[]) { | |||
| // ISO C++ does not allow 'main' to be used by a program [-Wmain] | |||
There was a problem hiding this comment.
Huh, never knew about this.
There was a problem hiding this comment.
Ya, clang top-of-tree is now warning about this by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.