[sil-parser] Fix harmless bug when parsing ossa. #26851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jckarter This is the reason why you weren't getting the ownership error when miswriting that test in the ossa PR. |
Specifically, we were preferring the always correct ownership kind specified by the FunctionType and ignoring what we parsed from the argument. This PR changes ossa to give a nice error when this is detected and fixes the places where this tests were written incorrectly.
gottesmm
force-pushed
the
pr-47fb2b3ffcc142eb6fe2703fdcbe61f25c7af463
branch
from
0ae75b1 to
af565e7
Compare
|
@swift-ci test and merge |
4 similar comments
|
@swift-ci test and merge |
|
@swift-ci test and merge |
|
@swift-ci test and merge |
|
@swift-ci test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, we were preferring the always correct ownership kind specified by
the FunctionType and ignoring what we parsed from the argument. This PR changes
ossa to give a nice error when this is detected and fixes the places where this
tests were written incorrectly.