[AppKit] Fix incorrect rawValue for NSEvent.SpecialKey.deleteForward #26853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the rawValue to match NSDeleteFunctionKey.
|
Nice catch! @swift-ci test |
This comment has been minimized.
This comment has been minimized.
|
@swift-ci test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the rawValue to match NSDeleteFunctionKey.
The NSEvent.SpecialKey.deleteForward rawValue is currently
0xF7028. This appears to be a typo, as the relevant AppKit docs say it should be0xF728.I noticed this when using a switch to handle NSEvent
specialKeyvalues, and testing the forward delete key. My case for .deleteForward was skipped, and the specialKey rawValue of the actual event was0xF728.