Store symbol byte offset in IndexSymbol #26858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urrent source file.
…ffset. The rest can be determined from the source manager by finding the token's SourceLoc.
akyrtzi
requested changes
Aug 27, 2019
…gned>, getOffsetInBuffer is now replaced by returning a tuple with the offset from getLineColAndOffset (renamed from getLineCol).
akyrtzi
requested changes
Aug 27, 2019
akyrtzi
approved these changes
Aug 27, 2019
|
@akyrtzi Is there something I need to do to trigger the smoke tests for this PR? |
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the offset field to the IndexSymbol struct. This lets code using swift::index functions skip any line/column -> offset reverse calculation if the specific byte offset location is desired.