[CS] Look at the fn's rvalue type in getCalleeLocator #26869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it slightly easier to spot cases where we've resolved to the wrong affected decl.
This makes sure we correctly resolve to the initialiser decl rather than an lvalue local variable of a metatype in the included test case.
|
*crosses fingers* @swift-ci please test |
|
Darn – I'll leave the honours up to you @xedin :) |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed this case when implementing #24826, we need to look at the function's rvalue type when deciding whether we have a short-form constructor call. I have also added a couple of assertions to
RequirementFailurethat should hopefully make it slightly easier to spot cases where we've resolved to the wrong affected decl.