ABI/API checker: always print fully qualified names for types when diagnosing module difference #26873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…agnosing module difference This change introduces a Json format change where we always print fully qualified type names everywhere. This is beneficial for diagnosing purposes but may not be ideal for generating migrator scripts. To resolve this conflict, the patch also introduces a flag -migrator to opt-out fully qualified type names. After the format change, we need to update the ABI and API baselines for the Swift stdlib.
|
@swift-ci please smoke test |
|
To make this format change fly without introducing a lot of false positives, I have to update the ABI/API baseline for the stdlib with the commit. However, the baseline is still generated from master instead of 5.1 branch. I plan to have a separate commit to fix rdar://54653088 cc: @stephentyrone and @lorentey |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a Json format change where we always print fully
qualified type names everywhere. This is beneficial for diagnosing purposes but
may not be ideal for generating migrator scripts. To resolve this conflict, the
patch also introduces a flag -migrator to opt-out fully qualified type names.
After the format change, we need to update the ABI and API baselines for the
Swift stdlib.