[semantic-arc-opts] Add a worklist. #26877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test and merge |
gottesmm
force-pushed
the
pr-283cbb40e1d2bae71f67901d5f94b51e04227029
branch
from
9c6120c to
3029054
Compare
|
@swift-ci test and merge |
4 similar comments
|
@swift-ci test and merge |
|
@swift-ci test and merge |
|
@swift-ci test and merge |
|
@swift-ci test and merge |
|
@swift-ci test os x platform |
1 similar comment
|
@swift-ci test os x platform |
We first build up the worklist by applying our visitor to the CFG via a simple instruction walk. During this walk, we know that we will only ever modify instructions that are dominated by the visited instruction since we do not look through basic block arguments. Then once we have finished traversing the CFG, optimizing and gathering opportunities, we drain the worklist. This is eventually where we should process block arguments that we may be able to optimize.
gottesmm
force-pushed
the
pr-283cbb40e1d2bae71f67901d5f94b51e04227029
branch
from
3029054 to
d8870fc
Compare
|
@swift-ci test and merge |
5 similar comments
|
@swift-ci test and merge |
|
@swift-ci test and merge |
|
@swift-ci test and merge |
|
@swift-ci test and merge |
|
@swift-ci test and merge |
atrick
reviewed
Aug 27, 2019
| // the instruction). | ||
| if (auto *defInst = next->getDefiningInstruction()) { | ||
| if (isInstructionTriviallyDead(defInst)) { | ||
| madeChange = true; |
There was a problem hiding this comment.
It looks to me like all this should be factored with the normal eraseAndRAUWSingleValueInstruction path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We first build up the worklist by applying our visitor to the CFG via a simple
instruction walk. During this walk, we know that we will only ever modify
instructions that are dominated by the visited instruction since we do not look
through basic block arguments.
Then once we have finished traversing the CFG, optimizing and gathering
opportunities, we drain the worklist. This is eventually where we should process
block arguments that we may be able to optimize.