[Request Evaluator] Begin Formalizing Zones #26892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
Begin refactoring the request evaluator by swapping SWIFT_TYPEID for SWIFT_REQUEST. Introduce the Zone of the request as a formal parameter to the macro, then re-expand the request macro to get the type info back. SWIFT_REQUEST will eventually grow to encompass more information about requests as we seek to reduce the boilerplate involved in their definitions.
Formally define the Zones in the TypeID header. This is not its final resting place.
|
OK, the merge conflicts have successfully got to me. I'm sorting these def files. @swift-ci please smoke test |
|
macOS failed CMark. Let’s try again @swift-ci please smoke test macOS platform |
|
⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Begin the road to refactoring the interface to defining requests by swapping out SWIFT_TYPEID for SWIFT_REQUEST. For now, SWIFT_REQUEST will still buy you everything that SWIFT_TYPEID does if you're a request. But, importantly, it includes the zone. Zones are now (temporarily) an enum class, and they all retain their original values (though none of this is important). All the places that were defining magic numbers in macros to pass as zones are kaput.
Ideally this patch is NFC.