Frontend: add a front-end option to specify module names for which we prefer loading via interfaces #26894
Conversation
|
@swift-ci please smoke test |
| // Dump Json file for cake ABI via .swiftinteface file | ||
| // RUN: %api-digester -dump-sdk -module cake -o - -module-cache-path %t.module-cache %clang-importer-sdk-nosource -I %t.mod1 -I %S/Inputs/APINotesLeft -abi -use-interface-for-module cake > %t.dump2.json | ||
|
|
||
| // Compare two Json files and we should see some differences. |
There was a problem hiding this comment.
Why are we seeing differences here? It looks like you're building the swiftmodule and the swiftinterface from the same build settings, so they should have identical public contents.
There was a problem hiding this comment.
Notice here we are comparing two Json files: the first Json file is a dump from loading the interface; the second Json file is a dump from loading the binary format generated directly from the source code. The difference is due to that source-generated swiftmodule files can diverge from the swiftmodule files generated from interface.
There was a problem hiding this comment.
If they do, that's a bug. How are these differences coming up?
… prefer to loading via interfaces ABI checker imports Swift frameworks by using Swift interfaces for various reasons. The existing way of controlling preferred importing mechanism is by setting an environment variable (SWIFT_FORCE_MODULE_LOADING), which may lead to performance issues because the stdlib could also be loaded in this way. This patch adds a new front-end option to specify module names for which we prefer to importing via Swift interface. The option currently is only accessible via swift-api-digester. rdar://54559888
nkcsgexi
force-pushed
the
frontend-opts-load-interface-for-module
branch
from
87c548c to
1e65666
Compare
|
@swift-ci please smoke test |
nkcsgexi
changed the title
| CacheDir, PrebuiltCacheDir, ModuleID.second, | ||
| RemarkOnRebuildFromInterface, dependencyTracker, | ||
| LoadMode); | ||
| llvm::is_contained(PreferInterfaceForModules, | ||
| ModuleName)? |
There was a problem hiding this comment.
Missing a space again.
| // RUN: %target-swift-frontend -typecheck -emit-parseable-module-interface-path %t.mod1/cake.swiftinterface %S/Inputs/cake_baseline/cake.swift -I %S/Inputs/APINotesLeft %clang-importer-sdk-nosource -parse-as-library -enable-library-evolution -disable-objc-attr-requires-foundation-module -module-cache-path %t.module-cache | ||
|
|
||
| // Generate .swiftmodule file for module cake | ||
| // RUN: %target-swift-frontend -emit-module -o %t.mod1/cake.swiftmodule %S/Inputs/cake_baseline/cake.swift -I %S/Inputs/APINotesLeft %clang-importer-sdk-nosource -parse-as-library -disable-objc-attr-requires-foundation-module -module-cache-path %t.module-cache |
There was a problem hiding this comment.
Oh, I see. You forgot -enable-library-evolution here.
There was a problem hiding this comment.
All of the other changes should not happen, and if they do that's a problem.
| @@ -42,8 +42,10 @@ class SerializedModuleLoaderBase : public ModuleLoader { | |||
| protected: | |||
| ASTContext &Ctx; | |||
| ModuleLoadingMode LoadMode; | |||
| ArrayRef<std::string> PreferInterfaceForModules; | |||
There was a problem hiding this comment.
Sorry I missed this the first time around. This doesn't belong in SerializedModuleLoaderBase; please move it up to ParseableInterfaceModuleLoader.
ABI checker imports Swift frameworks by using Swift interfaces for various
reasons. The existing way of controlling preferred importing mechanism is by
setting an environment variable (SWIFT_FORCE_MODULE_LOADING), which may lead
to performance issues because the stdlib could also be loaded in this way.
This patch adds a new front-end option to specify module names for
which we prefer importing via Swift interface. The option currently is only
accessible via swift-api-digester.
rdar://54559888