Skip to content

[SyntaxParse] use parseGenericArgumentClauseSyntax() #26914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 29, 2019
Merged

[SyntaxParse] use parseGenericArgumentClauseSyntax() #26914

merged 2 commits into from
Aug 29, 2019

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Aug 28, 2019

To parse generic arguments for types. There's no reason to use AST version of it.

@rintaro
Copy link
Member Author

rintaro commented Aug 28, 2019

@swift-ci Please smoke test

@rintaro rintaro force-pushed the syntaxparse-genericargsyntax branch from 8b4c1bd to c33c91f Compare August 28, 2019 22:26
@rintaro
Copy link
Member Author

rintaro commented Aug 28, 2019

@swift-ci Please smoke test

@rintaro rintaro force-pushed the syntaxparse-genericargsyntax branch from c33c91f to dd24354 Compare August 28, 2019 22:45
@rintaro
Copy link
Member Author

rintaro commented Aug 28, 2019

@swift-ci Please smoke test

@rintaro rintaro force-pushed the syntaxparse-genericargsyntax branch from dd24354 to 45f3ba2 Compare August 28, 2019 23:28
@rintaro
Copy link
Member Author

rintaro commented Aug 28, 2019

@swift-ci Please smoke test

@rintaro rintaro force-pushed the syntaxparse-genericargsyntax branch from 45f3ba2 to bdda81c Compare August 28, 2019 23:43
@rintaro
Copy link
Member Author

rintaro commented Aug 29, 2019

@swift-ci Please smoke test

@rintaro rintaro merged commit 0899eb6 into swiftlang:master Aug 29, 2019
rintaro added a commit to rintaro/swift that referenced this pull request Oct 14, 2019
@rintaro
Revert "Merge pull request swiftlang#26914 from rintaro/syntaxparse-g…
71aa44d 
…enericargsyntax"

This reverts commit 0899eb6, reversing
changes made to b8f42d6.
rintaro added a commit to rintaro/swift that referenced this pull request Oct 14, 2019
@rintaro
Revert "Revert "Merge pull request swiftlang#26914 from rintaro/synta…
1ce0abb 
…xparse-genericargsyntax""

This reverts commit 71aa44d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rintaro