[test] Remove redirection stderr->out that corrupted output. #26916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RUN line was redirecting stderr to stdout, but nothing in the test was checking for the stderr output. However, the last line of stderr was an empty newline, which was printed (in my machine) in the middle of the dump from the AST, breaking the test. If we ever need to check the stderr, it should be redirected to a file, and the file should be passed to FileCheck independently, to avoid concurrent uses of the output buffer.
|
@swift-ci please smoke test |
pschuh
approved these changes
Aug 28, 2019
|
Thanks for fixing! This was added back when |
|
Makes sense. Thanks for explaining the reason! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RUN line was redirecting stderr to stdout, but nothing in the test
was checking for the stderr output.
However, the last line of stderr was an empty newline, which was printed
(in my machine) in the middle of the dump from the AST, breaking the
test.
If we ever need to check the stderr, it should be redirected to a file,
and the file should be passed to FileCheck independently, to avoid
concurrent uses of the output buffer.
A similar change was performed in 39d3963 to the second line of the test.
/cc @akyrtzi