[AutoDiff] Temporarily disable non-varied result warning. #26928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a warning and fixit was generated for differentiable functions with non-varied results. ``` tf-775.swift:3:3: warning: result does not depend on differentiation arguments and will always have a zero derivative; do you want to use 'withoutDerivative(at:)'? .zero ^ withoutDerivative(at: ) ``` However, TF-775 exposes that the fixit does not work and the warning is unsilenceable. This patch temporarily disables the warning, as a robust fix requires non-trivial activity analysis changes. A lack of warning is better than an unsilenceable false positive. TF-788 tracks re-enabling the warning. Add regression test to ensure that unsilenceable warnings will not happen again.
|
@swift-ci Please test tensorflow |
rxwei
approved these changes
Aug 29, 2019
dan-zheng
added a commit
to bartchr808/swift
that referenced
this pull request
Sep 19, 2019
Follow-up to swiftlang#26928 for reverse-mode. TF-788 tracks re-enabling the warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a warning and fixit was generated for differentiable functions
with non-varied results.
However, TF-775 exposes that the fixit does not work and the warning is unsilenceable.
This patch temporarily disables the warning, as a robust fix requires non-trivial activity analysis changes. A lack of warning is better than an unsilenceable false positive.
TF-788 tracks re-enabling the warning.
Add regression test to ensure that unsilenceable warnings will not happen again.