Pass libdispatch source and build directories to Swift PM #2693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also: swiftlang/swift-package-manager#369 |
|
@gribozavr Would it be possible to get a review of this - if your happy with it I'll do the work to update for the merge conflict. Note that the counterpart in SwiftPM is already merged. |
seabaylea
force-pushed
the
dispatch-swiftpm
branch
from
132f0a9 to
8788abe
Compare
|
Ok, I've gone ahead and fixed the merge conflict and updated the branch. |
|
LGTM. @swift-ci Please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
The new dependency between Swift Package Manager and Foundation means that there's a compilation failure if Dispatch is built into Foundation.
This passes the libdispatch source and build directories to Swift PM build script to that it can add them to the import paths.
Resolved bug number: (SR-)
N/A
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.