Add Quote to update-checkout-config.json #26934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently, we've given up on #26708 which was trying to include Quote in the apple/swift:tensorflow build. However, we still need a little bit of that PR in order to keep track of which version of Quote the quoting logic in the compiler depends on. It is somewhat awkward to clone Quote during the build and then not use it afterwards, but that's the best that our current infrastructure allows us.
|
@swift-ci please clean test tensorflow |
bgogul
approved these changes
Aug 29, 2019
| @@ -38,6 +38,8 @@ | |||
| "remote": { "id": "tensorflow/tensorflow" } }, | |||
| "tensorflow-swift-apis": { | |||
| "remote": { "id": "tensorflow/swift-apis" } }, | |||
| "tensorflow-swift-quote": { | |||
There was a problem hiding this comment.
Just a heads up. Our internal imports expect 'tensorflow-swiftas a the key. If you want to usetensorflow-swift-quote`, the internal imports need to be changed too.
There was a problem hiding this comment.
Yes, that's the next step. Thanks for the reminder!
AnthonyLatsis
added
the
update-checkout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, we've given up on #26708 which was trying to include Quote in the apple/swift:tensorflow build.
However, we still need a little bit of that PR in order to keep track of which version of Quote the quoting logic in the compiler depends on.
It is somewhat awkward to clone Quote during the build and then not use it afterwards, but that's the best that our current infrastructure allows us.