[Runtime] Fix gatherWrittenGenericArgs crashing when description is NULL #26936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DougGregor Can you verify that this is the proper fix? I think this is just a missing NULL check but I want to double-check and make sure I'm not actually papering over the real problem. |
mikeash
force-pushed
the
null-was-a-mistake
branch
2 times, most recently
from
4e0d13b to
e396bd8
Compare
DougGregor
approved these changes
Aug 30, 2019
|
Thanks Doug! That’s what I thought, but wanted to be sure I didn’t miss something. |
|
@swift-ci please test and merge |
1 similar comment
|
@swift-ci please test and merge |
…ULL. rdar://problem/54775582 SR-11374
mikeash
force-pushed
the
null-was-a-mistake
branch
from
e396bd8 to
5decec2
Compare
|
@swift-ci please test and merge |
1 similar comment
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://problem/54775582
SR-11374