build: dereference variable as appropriate #26938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain versions of CMake behave differently with variable expansion. This may be evaluated incorrectly in some versions. Dereference the value explicitly.
|
@swift-ci please smoke test |
|
CC: @drodriguez |
jrose-apple
reviewed
Aug 30, 2019
| @@ -2370,7 +2370,7 @@ function(_add_swift_executable_single name) | |||
| # NOTE(compnerd) use the C linker language to invoke `clang` rather than | |||
| # `clang++` as we explicitly link against the C++ runtime. We were previously | |||
| # actually passing `-nostdlib++` to avoid the C++ runtime linkage. | |||
| if(SWIFTEXE_SINGLE_SDK STREQUAL ANDROID) | |||
| if(${SWIFTEXE_SINGLE_SDK} STREQUAL ANDROID) | |||
There was a problem hiding this comment.
Nitpick: you should quote this so it can't get expanded again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain versions of CMake behave differently with variable expansion. This may
be evaluated incorrectly in some versions. Dereference the value explicitly.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.