[Diagnostics] Treat type requirement failures associated with Self …
#26941
Conversation
…= `Any` as unrelated
This helps us to filter out cases like operator overloads where
`Self` type comes from e.g. default for collection element -
`[1, "hello"].map { $0 + 1 }`. Main problem here is that
collection type couldn't be determined without unification to
`Any` and `+` failing for all numeric overloads is just a consequence.
| @@ -182,8 +182,7 @@ func r22162441(_ lines: [String]) { | |||
|
|
|||
| func testMap() { | |||
| let a = 42 | |||
| [1,a].map { $0 + 1.0 } // expected-error {{binary operator '+' cannot be applied to operands of type 'Any' and 'Double'}} | |||
| // expected-note @-1 {{expected an argument list of type '(Double, Double)'}} | |||
| [1,a].map { $0 + 1.0 } // expected-error {{cannot convert value of type 'Int' to expected element type 'Double'}} | |||
There was a problem hiding this comment.
It's still not quite right is it? The diagnostic talks about an 'element type' but that's Int here isn't it?
There was a problem hiding this comment.
It's not really Int, since there is a literal which could be a Double as well, which would match + inside of the closure body.
There was a problem hiding this comment.
I see it from the perspective that if there was no a in there, everything would have type-checked correctly as [Double].
There was a problem hiding this comment.
Only other possible failure we could produce would say that $0 expected to be Double which might not be more useful since it still comes down to use of a.
|
@swift-ci please smoke test |
|
If there are no objections I'm going to merge this pretty soon since it helps to make progress with other diagnostics. |
…=
Anyas unrelatedThis helps us to filter out cases like operator overloads where
Selftype comes from e.g. default for collection element -[1, "hello"].map { $0 + 1 }. Main problem here is thatcollection type couldn't be determined without unification to
Anyand+failing for all numeric overloads is just a consequence.