[semantic-arc-opts] Change semantic arc opts to use a SmallBlotSetVec… #26945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor instead of a SmallSetVector. Blotting is a trick with Map/Set vectors that involves one assigning None to the vector at the index mapped to an entry instead of deleting the entry itself from the vector. This ensures that we do not need to move elements of the vector down when erasing elements from the worklist.
|
@swift-ci smoke test |
|
@nate-chandler @atrick I realized in our conversation today I was using a set vector here instead of a blot set vector. Our conversation inspired me to fix this. |
|
Wow! We should never call vector::erase. I wonder how many times that's slipped through the cracks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tor instead of a SmallSetVector.
Blotting is a trick with Map/Set vectors that involves one assigning None to the
vector at the index mapped to an entry instead of deleting the entry itself from
the vector. This ensures that we do not need to move elements of the vector down
when erasing elements from the worklist.