[Sema] Synthesize pre-type-checked ASTs for more derived conformances #26946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix rdar://problem/54712316, a case where the non-type-checked AST was getting processed by SILGen.
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
Otherwise, the standard library won't build ;)
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
1 similar comment
|
@swift-ci please test source compatibility |
slavapestov
reviewed
Aug 30, 2019
| if (!hashFunc->hasInterfaceType()) | ||
| static_cast<TypeChecker *>(C.getLazyResolver())->validateDecl(hashFunc); | ||
|
|
||
| auto substitutions = SubstitutionMap::get( |
There was a problem hiding this comment.
This should get SubstitutionMap::getProtocolSubstitutions()
There was a problem hiding this comment.
No, never mind: it's not a protocol method, it's a free function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synthesize pre-type-checked ASTs for a few places where we are deriving conformances:
hashValue==for uninhabited enums==for enums whose cases have no associated valuesShould fix rdar://problem/54712316, a case where the non-type-checked
AST was getting processed by SILGen.