[Diagnostics] [Typechecker] Emit fix-its for witness mismatches #26990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrose-apple
reviewed
Sep 3, 2019
|
Forgot to say: thanks for picking these up! |
…en prefix/postfix is missing
|
@swift-ci please smoke test |
…Conflict, so guard against that
|
@swift-ci please smoke test |
jrose-apple
reviewed
Sep 4, 2019
jrose-apple
approved these changes
Sep 4, 2019
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw a couple of FIXMEs, so I decided to address them and then also add fix-its for the rest of the cases.
This PR adds fix-its for when the witness does not match the requirements.
@nonobjccase because the attribute's location does not look correct when I pass it tofixItReplace(i.e. the replaced range does not look correct).nonmutatingand one for__consuming.