Requestify Inferring Generic Requirements #26995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unify a bunch of quasi-independent callsites into a single request that builds up a generic signature from a variety of inference sources. This draws the extension typealias workaround for SE-0229 into TypeCheckDecl where we can better work on refactoring it. The goal is to use this as a springboard to requests that compute generic environments for various and sundry decls.
CodaFi
force-pushed
the
a-sign-from-on-high
branch
from
f22a2c7 to
87047d0
Compare
|
Unfortunately, only code structure improvements in this one. No perf improvements from laziness - seems like we were already doing a pretty good job of minimizing our construction of GSBs here. |
|
@swift-ci please test |
Azoy
reviewed
Sep 3, 2019
| auto sig = nominal->getGenericSignatureOfContext(); | ||
| if (!sig) return static_cast<unsigned>(-1); | ||
|
|
||
| return sig->getGenericParams().back()->getDepth(); |
There was a problem hiding this comment.
return nominal->getGenericContextDepth(); ?
There was a problem hiding this comment.
I don't think we need a context walk here if we already have this information available in this (admittedly baroque) form. There's quite a few places in the compiler that are computing depths this way. Perhaps we should look into unifying them.
|
Build failed |
|
Build failed |
|
@swift-ci please test |
|
⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify a bunch of quasi-independent callsites into a single request that
builds up a generic signature from a variety of inference sources. This
draws the extension typealias workaround for SE-0229 into TypeCheckDecl
where we can better work on refactoring it. The goal is to use this as
a springboard to requests that compute generic environments for various
and sundry decls.