A small step towards removing C-style loops #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll run tests and merge. |
| @@ -29,8 +29,8 @@ struct _Prespecialize { | |||
| a[0] = a[j] | |||
| } | |||
|
|
|||
| for var i1 = 0; i1 < a.count; ++i1 { | |||
| for var i2 = 0; i2 < a.count; ++i2 { | |||
| for i1 in 0..<a.count { | |||
There was a problem hiding this comment.
Shouldn't this use a.indices?
gribozavr
added a commit
that referenced
this pull request
Dec 6, 2015
A small step towards removing C-style loops
|
@dabrahams Just noticed your comment. I'll take care of that. EDIT: Implemented in 403b46c. |
|
@gribozavr I don't mean to sound cheesy, but this is the first commit I've ever made to a programming language ever. Thank you 😄 |
|
@hamin You're welcome! 💯 |
slavapestov
pushed a commit
to slavapestov/swift
that referenced
this pull request
Nov 27, 2018
…options link swift libraries when building test executables
kateinoigakukun
pushed a commit
to kateinoigakukun/swift
that referenced
this pull request
Mar 5, 2020
[pull] swiftwasm from master
freak4pc
pushed a commit
to freak4pc/swift
that referenced
this pull request
Sep 28, 2022
Update Lark to Swift 4.2, resolves XFAIL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small step towards removing C-style loops in favor of Swift for/in loops as presented in this accepted proposal:https://github.com/apple/swift-evolution/pull/23/commits . Nothing big here, just getting my feet wet and trying help improve code quality :)