Mangle associated types of opaque types like dependent member types. … #27014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
The archetype mangling does not have enough information to accurately recover the associated type at runtime. This fixes rdar://problem/54084733. Although this changes the mangling in both runtime and symbols, this should not affect ABI, because there is no way for associated types of opaque types to be surfaced in the types of public declarations today.
If we mangled an opaque associated type while targeting an older OS, we can use a \9 accessor reference string to instantiate the associated type.
jckarter
force-pushed
the
opaque-type-assoc-type-mangling
branch
from
1581dcf to
0ae86c9
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nested archetype mangling does not have enough information to accurately recover the associated type at runtime. This fixes rdar://problem/54084733.
Although this changes the mangling in both runtime and symbols, this should not affect ABI, because there is no way for associated types of opaque types to be surfaced in the types of public
declarations today.
Shipping Swift 5.1 runtimes do not support this new mangling, so back-deploy the fix by emitting a mangled string that refers to a
\9accessor function when targeting Swift 5.1.