[SIL] Extracted SILInstructionWorklist from SILCombine. #27020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
nate-chandler
commented
Sep 4, 2019
gottesmm
reviewed
Sep 4, 2019
nate-chandler
force-pushed
the
instruction-worklist
branch
2 times, most recently
from
1c73855 to
d80eede
Compare
|
@swift-ci please test and merge |
SILCombine had a dedicated worklist type that is generally useful. Here that type is extracted into SIL as SILInstructionWorklist so that it can be reused. Minor style changes were made as well.
In the previous commit, SILInstructionWorklist was added as a verbatim extraction (modulo some minor style tweaks) of SILCombineWorklist. Here, SILCombine is moved over to using that renamed type.
nate-chandler
force-pushed
the
instruction-worklist
branch
from
d80eede to
1eacf8b
Compare
|
@swift-ci please test and merge |
1 similar comment
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SILCombinehad a dedicated worklist type that is generally useful. Here that type is extracted into SIL asSILInstructionWorklistso that it can be reused. Minor style changes were made as well.In a second commit, SILCombine is moved over to using that renamed type.