[5.1] IRGen: Save the current generic signature before mangling an opaque type decl #27022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aque type decl
It comes with its own generic signature.
Explanation: We crash generating the mangling for an opaque type decl.
Scope of Issue: Affects code that uses opaque result types.
The compiler will crash.
Risk: Low. We cache and restore a generic signature before mangling opaque type
decls which will introduce their own generic signature.
Review: Joe Groff
Testing: Swift regression test added.
rdar://54824119
|
@swift-ci Please test |
|
Build failed |
|
@swift-ci Please test linux |
slavapestov
reviewed
Sep 5, 2019
| @@ -735,7 +735,9 @@ void ASTMangler::appendOpaqueDeclName(const OpaqueTypeDecl *opaqueDecl) { | |||
| if (canSymbolicReference(opaqueDecl)) { | |||
| appendSymbolicReference(opaqueDecl); | |||
| } else if (auto namingDecl = opaqueDecl->getNamingDecl()) { | |||
| CanGenericSignature savedSignature = CurGenericSignature; | |||
There was a problem hiding this comment.
Should CurGenericSignature be a stack then, with an RAII utility to save and restore the signature?
There was a problem hiding this comment.
llvm::SaveAndRestore is a good way to indicate what's happening here
airspeedswift
approved these changes
Sep 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It comes with its own generic signature.
Explanation: We crash generating the mangling for an opaque type decl.
Scope of Issue: Affects code that uses opaque result types.
The compiler will crash.
Risk: Low. We cache and restore a generic signature before mangling opaque type
decls which will introduce their own generic signature.
Review: Joe Groff
Testing: Swift regression test added.
rdar://54824119
Master PR: #27017