[Diagnostics] Extend the AllowInOutConversion fix to cover inout attribute mismatches in function types.
#27043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
xedin
reviewed
Sep 5, 2019
xedin
reviewed
Sep 5, 2019
| @@ -1289,7 +1289,7 @@ class IgnoreContextualType : public ContextualMismatch { | |||
| }; | |||
|
|
|||
| /// If this is an argument-to-parameter conversion which is associated with | |||
| /// `inout` parameter, subtyping is now permitted, types have to | |||
| /// `inout` parameter, subtyping is not permitted, types have to | |||
…tribute mismatches in function types. This improves the diagnostic in cases where we have argument-to-parameter conversion failures or contextual type mismatches due to inout attribute mismatches.
hborla
force-pushed
the
inout-attr-mismatch-diag
branch
from
f0213b0 to
7277f4f
Compare
|
@swift-ci please smoke test |
slavapestov
reviewed
Sep 5, 2019
| return { | ||
| x in () | ||
| } | ||
| } | ||
| var _: (inout X) -> () = makef() // expected-error{{generic parameter 'T' could not be inferred}} | ||
| var _: (inout X) -> () = makef() // expected-error{{cannot convert value of type '(X) -> ()' to specified type '(inout X) -> ()'}} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the diagnostic in cases where we have argument-to-parameter conversion failures or contextual type mismatches due to inout attribute mismatches.
Example:
Previously, we would diagnose
cannot convert value of type '(inout Int) -> Void' to expected argument type '(inout _) -> Void'. Now, we diagnosecannot convert value of type '(Int) -> Void' to expected argument type '(inout Int) -> Void'.