[SyntaxParse] Refactor parsing facilities #27046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
changed the title
|
@swift-ci Please smoke test |
rintaro
force-pushed
the
syntaxparse-refactor-type
branch
2 times, most recently
from
5bc080b to
cf9a2e9
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Linux |
- Utilize ignoreToken() to skip tokens while keeping them in syntax tree - SyntaxParsedResult now holds ParsedRawSyntaxNode and ParserStatus - Simplify migration support for 'TypeName[]' type - Use builder for generic argument clause parsing
|
@swift-ci Please smoke test |
Fixes memory leak for 'TypeName<,'
So popIf() never pops parent functions storage.
rintaro
force-pushed
the
syntaxparse-refactor-type
branch
from
cf9a2e9 to
4a3a95b
Compare
|
@swift-ci Please smoke test |
rintaro
added a commit
to rintaro/swift
that referenced
this pull request
Oct 14, 2019
…xparse-refactor-type"" This reverts commit 62408b0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignoreToken()to skip tokens while keeping them in result syntax tree. When a token is skipped, it become a part of leading trivia of the next token.SyntaxParsedResultholds onlyParsedRawSyntaxNodeandParserStatusASTGen::advanceLocEnd()functionSyntaxParserResulttypeTypeName[]type fromASTGen. NowparseTypeArray()constructArrayTypeSyntaxwith missing/ignored tokens.